Fix crash caused by USB device disconnection during permission grant - #86
Open
KairuiLiu wants to merge 1 commit into
Open
Fix crash caused by USB device disconnection during permission grant#86KairuiLiu wants to merge 1 commit into
KairuiLiu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsbManager.openDevice()to return null andgetSerialNumber()to throw an uncaughtSecurityException, killing the process.USBMonitorand adapt the Flutter plugin caller accordingly.Root Cause
When a USB device is unplugged while the system permission dialog is still showing, the following race occurs:
Changes
USBMonitor.java—UsbControlBlock()openDevice()return value; throwIOExceptionif null instead of proceeding togetSerialNumber()USBMonitor.java—updateDeviceInfo()getSerialNumber()/getManufacturerName()/getProductName()in try-catch forSecurityException; early-return ifopenDevice()returns nullUSBMonitor.java—processConnect()IOExceptionfromUsbControlBlockconstructor, log warning, and callprocessCancel()to notify listeners gracefullyUSBMonitor.java—openDevice()throws IOExceptionto method signatureUvcCameraPlatform.javaIOExceptiononopenDevice(), wrap asIllegalStateException